Skip to content

svelte import sort#310

Merged
byara merged 8 commits into
trivago:v5from
canarddemagret:svelte-import-sort
Nov 25, 2024
Merged

svelte import sort#310
byara merged 8 commits into
trivago:v5from
canarddemagret:svelte-import-sort

Conversation

@canarddemagret
Copy link
Copy Markdown
Contributor

I saw @secondfry did a PR but closed itself.

It is just the same PR with a "postinstall": "patch-package" in the package.json so the prettier-plugin-svelte works

@secondfry
Copy link
Copy Markdown

I've closed my PR because upon additional inspection I didn't need any of these. What I've needed was an update to recent SvelteKit and proper eslint plugins.

@byara byara changed the base branch from main to v5 November 22, 2024 09:51
@byara byara requested review from ayusharma and byara and removed request for ayusharma November 22, 2024 09:52
@byara byara force-pushed the svelte-import-sort branch from 66c1567 to d7bdc8c Compare November 22, 2024 10:58
@byara byara merged commit e427746 into trivago:v5 Nov 25, 2024
@byara byara mentioned this pull request Dec 4, 2024
@MoritzWeber0
Copy link
Copy Markdown

MoritzWeber0 commented Dec 6, 2024

Optional peer dependencies seem to be installed by default in parent projects. This leads to to svelte being installed in all projects, also projects that don't use Svelte at all. That is probably not intentional.

See also: #323

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants